Fix error thrown in compiled-binaryop benchmark#10398
Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-22.04from Mar 9, 2022
Merged
Fix error thrown in compiled-binaryop benchmark#10398rapids-bot[bot] merged 1 commit intorapidsai:branch-22.04from
rapids-bot[bot] merged 1 commit intorapidsai:branch-22.04from
Conversation
davidwendt
added
bug
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10398 +/- ##
=================================================
+ Coverage 10.50% 86.13% +75.62%
=================================================
Files 127 139 +12
Lines 21200 22433 +1233
=================================================
+ Hits 2228 19323 +17095
+ Misses 18972 3110 -15862
Continue to review full report at Codecov.
|
karthikeyann
approved these changes
Mar 8, 2022
Contributor
karthikeyann
left a comment
karthikeyann
left a comment
There was a problem hiding this comment.
LGTM 👍
Thanks for doing this.
This fix is already part of PR #10109
ttnghia
approved these changes
Mar 8, 2022
Contributor
Author
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
BINARYOP_BENCHwhich is throwing an error for non-numeric types:The
compiled_binaryop.cppwas recently changed in #10300 to create test columns using the benchmark utilitycreate_sequence_tablewhich internally callscudf::sequenceAPI. Unfortunately, onlynumerictypes can be used with this API which throws an error for types liketimestamp, duration, and decimalwhich are being measured in this file. https://docs.rapids.ai/api/libcudf/stable/group__transformation__fill.html#gaeda630c9dcdd152eeecf0a1b636244acThe fix replaces the
create_sequence_tablecall withcreate_random_tableto generate the source columns instead.